Rename CMake target 'executorch' to 'prim_ops_lib' for clarity #11786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed executorch target to prim_ops_lib in CMakeLists.txt - Added executorch as an alias for backward compatibility - Updated executorch-config.cmake to use prim_ops_lib - Removed redundant manual target_link_options_shared_lib calls in examples - Updated documentation to reflect the new target name
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 20 New Failures, 4 Unrelated FailuresAs of commit 7b207f6 with merge base a0618c8 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @JawadKhan65! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@pytorchbot label "release notes: build" |
pytorch-bot
bot
added
the
release notes: build
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
…an65/executorch into rename-executorch-target
|
@JawadKhan65 Sorry for the slow response - I know it's a bad look from the framework's perspective. I've triggered CI runs on the PR, and it looks like there are a few remaining tweaks needed. If we can get those resolved, I'll stamp and we can merge it. Thanks! |
|
Fixes #11761. |
Comment on lines
+492
to
500
| TARGETS prim_ops_lib executorch_core | ||
| INCLUDES | ||
| DESTINATION ${_common_include_directories} | ||
| ) | ||
| #prim_ops_lib install | ||
| install( | ||
| TARGETS prim_ops_lib executorch_core | ||
| INCLUDES | ||
| DESTINATION ${_common_include_directories} |
There was a problem hiding this comment.
Seems like duplicate? We just need one of the installs
| # Find prebuilt libraries. executorch package should contain portable_ops_lib, | ||
| # etdump, bundled_program. | ||
| find_package(executorch CONFIG REQUIRED) | ||
| target_link_options_shared_lib(executorch) | ||
| # Note: target_link_options_shared_lib(prim_ops_lib) is now called automatically in executorch-config.cmake |
| @@ -37,7 +37,7 @@ set(_common_include_directories ${EXECUTORCH_ROOT}/..) | |||
| # Find prebuilt libraries. executorch package should contain portable_ops_lib, | |||
| # etdump, bundled_program. | |||
| find_package(executorch CONFIG REQUIRED) | |||
| target_link_options_shared_lib(executorch) | |||
| # Note: target_link_options_shared_lib(prim_ops_lib) is now called automatically in executorch-config.cmake | |||
| @@ -78,7 +78,7 @@ find_package(gflags REQUIRED) | |||
| # find `executorch` libraries Same as for gflags | |||
| set(executorch_DIR ${CMAKE_CURRENT_BINARY_DIR}/../../../lib/cmake/ExecuTorch) | |||
| find_package(executorch CONFIG REQUIRED) | |||
| target_link_options_shared_lib(executorch) | |||
| # Note: target_link_options_shared_lib(prim_ops_lib) is now called automatically in executorch-config.cmake | |||
| @@ -61,7 +61,10 @@ set_target_properties(fbjni PROPERTIES | |||
| ) | |||
|
|
|||
| set(executorch_DIR ${CMAKE_CURRENT_BINARY_DIR}/../../lib/cmake/ExecuTorch) | |||
| target_link_options_shared_lib(executorch) | |||
|
|
|||
| find_package(executorch CONFIG REQUIRED) | |||
There was a problem hiding this comment.
Hmm we don't need this right?
Comment on lines
+66
to
+67
| # target_link_options_shared_lib(executorch) is now handled by executorch-config.cmake | ||
|
|
| @@ -56,6 +56,7 @@ endforeach() | |||
| set(EXECUTORCH_FOUND ON) | |||
|
|
|||
| target_link_libraries(executorch INTERFACE executorch_core) | |||
| target_link_options_shared_lib(prim_ops_lib) | |||
There was a problem hiding this comment.
Can you add this to line 177?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the CMake target
executorchtoprim_ops_libfor better clarity, as the name more accurately reflects its purpose as the library for primitive operations.Changes:
executorchtarget toprim_ops_libin root CMakeLists.txtadd_library(executorch ALIAS prim_ops_lib)for backward compatibilityexecutorch-config.cmaketo calltarget_link_options_shared_lib(prim_ops_lib)target_link_options_shared_libin examples and backends:Testing:
Benefits: